as we are waiting for task assignments we go on to dig deeper into the codes,
just to discover even more code smells.
- hardcoded SQL statement and query logic in JSP
- string comparisons using "==", which leads to unreachable blocks of code
- though JDBC connection factories(see previous post) are in place, there are still direct inline creations of JDBC connection.
- direct dependency from domain object to JDBC API
- and....what the hell is this?
No comments:
Post a Comment