i was transferred to another project this morning on an urgent request to meet the schedule.
the project was in charged by the in-house development team of my client,
it is a straight forward web app with member subscription screen flow.
it was after i checked out all the codes to only realize that this project is such a disaster.
firstly with the requirements given i dont really expect a sophisticated architecture,
but a plain servlet + jsp web project started in 2010 indeed surprised me.
as i glanced through the code there are lots of code smells,
- extremely unorganized packages, looks like every one of them was doing his/her own project.
- JDBC connection factory classes (yes, there are more than one, checked in by different developers, apparently they are not from the same university so the coding style are different) with hardcoded connection properties.
- there are even business methods defined in one of the factory classes above.
- SQL statements by string concatenations (you think SQL-injections are so 90's huh?)
just to name a few.
wow..ging ar...Servlet + JSP
ReplyDeleteI remember I helped smartone to implement a very small IVR management system about two years ago. They specified they must use Servlet + Plain JSP only. No Strut Please...